Update damping values for jolt rigid bodies on mode switch at runtime #100473
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
changed the title
mihe
requested changes
Dec 17, 2024
mihe
requested changes
Dec 17, 2024
|
Also, since it'll probably get brought up eventually, note that Godot's contribution workflow (seen here) specifies that pull requests should ideally be a single commit, so you'll need to squash (and force push) your commits yourself before the PR can be merged. |
|
But there's no need to squash yet only when it's actually approved and ready to merge |
mihe
approved these changes
Dec 17, 2024
opsocket
force-pushed
the
fix-rigid-bodies-damping
branch
from
7d4fb36 to
0dd072b
Compare
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Here's a fix for an issue where linear_damp and angular_damp are not updated when either linear_damp_mode or angular_damp_mode is changed at runtime.
Previously, linear_damp and angular_damp were computed once using their initial damping mode and not updated whenever a mode was changed.
It's likely that we want to split that update operation for each damping type.
I've made a short demo, cube A and B are the same but they change their linear damping mode when they collide with a floor surface, the red one changes the mode to REPLACE while the blue one changes the mode to COMBINE.
The initial mode is COMBINE for both and they have the same initial velocity in opposite directions.
The default linear damping value is
.5.damping.mp4
Here's the same demo without the fix (which means damping is not updated when cube A damping mode is changed when it first collides with the red surface)
damped.mp4